Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL parsing bug #4998

Merged
merged 16 commits into from
Sep 29, 2021
Merged

Fix URL parsing bug #4998

merged 16 commits into from
Sep 29, 2021

Conversation

kalenmike
Copy link
Member

@kalenmike kalenmike commented Sep 29, 2021

Fixes an error where pathlib incorrectly detects the name for some URLs. Used when passing an authenticated url as the data argument

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improvement in file name parsing for remote file downloading.

📊 Key Changes

  • Simplified the parsing of file names from URLs by changing the order of operations—first stripping the query parameters and then extracting the name.

🎯 Purpose & Impact

  • Enhances File Handling: This tweak ensures that file names are extracted correctly, without any appended URL parameters that could cause errors.
  • Improves Robustness: The update strengthens the download process, preventing potential file naming issues and ensuring successful downloads for users.
  • User Experience: Users dealing with remote files can expect a more seamless experience with less risk of encountering file-related errors while using the code.

@glenn-jocher
Copy link
Member

Got it! I'm going to try to bring your branch up to speed with master /rebase

@glenn-jocher glenn-jocher changed the title Bug fix/url parsing Fix URL parsing bug Sep 29, 2021
@glenn-jocher glenn-jocher merged commit 76d301b into ultralytics:master Sep 29, 2021
@glenn-jocher
Copy link
Member

@kalenmike PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐

BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* added callbacks

* added back callback to main

* added save_dir to callback output

* merged in upstream

* removed ghost code

* fixed parsing error for google temp links

Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants