Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert torch.hub.load() test #4986

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Revert torch.hub.load() test #4986

merged 1 commit into from
Sep 29, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 29, 2021

Temporarily reverts #4978 until torch 1.10 is released, which should resolve urllib.error.HTTPError: HTTP Error 403: rate limit exceeded errors generated by torch hub from GitHub actions runners that is currently causing CI failures.

See pytorch/vision#4156 for details.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improving CI workflow robustness by noting a known HTTP 403 error. πŸ› οΈ

πŸ“Š Key Changes

  • Commented out the line in CI testing that loads a model from Ultralytics's GitHub to avoid a known urllib.error.HTTPError: HTTP Error 403: rate limit exceeded.
  • Added a comment explaining the issue and indicating it will be resolved in the upcoming torch==1.10.0 release.

🎯 Purpose & Impact

  • πŸ”— The change prevents CI from failing due to GitHub rate limiting, which is important for maintaining a smooth continuous integration process.
  • πŸ›‘οΈ This is a temporary workaround until the issue is resolved in PyTorch's future release, ensuring developers are aware of the limitation and the CI testing does not get obstructed by external HTTP errors.
  • πŸš€ For users, this means better reliability in the project's development workflow, potentially leading to quicker releases and bug fixes since CI plays a crucial role in the quality control process.

Temporarily reverts #4978 until torch 1.10 is released, which should resolve `urllib.error.HTTPError: HTTP Error 403: rate limit exceeded` errors generated by torch hub from GitHub actions runners.
@glenn-jocher glenn-jocher self-assigned this Sep 29, 2021
@glenn-jocher glenn-jocher merged commit cd35a00 into master Sep 29, 2021
@glenn-jocher glenn-jocher deleted the fix/ci_hub branch September 29, 2021 03:11
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Temporarily reverts ultralytics#4978 until torch 1.10 is released, which should resolve `urllib.error.HTTPError: HTTP Error 403: rate limit exceeded` errors generated by torch hub from GitHub actions runners.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant