Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative ROOT Pytorch Hub custom model bug #4974

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 28, 2021

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhancement of ROOT directory path handling in TensorFlow and YOLO model scripts.

πŸ“Š Key Changes

  • Commented out the conversion of ROOT to a relative path in both tf.py and yolo.py.
  • The ROOT directory variable now remains as an absolute path, as opposed to being converted to a relative path based on the current working directory.

🎯 Purpose & Impact

  • This change could potentially resolve issues related to path handling, which can vary depending on the user's current working directory.
  • Users may see improvements in the ease of importing and utilizing these models within different project structures.
  • It simplifies the code by removing an operation that could cause confusion or path resolution errors in various environments. πŸ› οΈπŸ”

@glenn-jocher glenn-jocher merged commit fb982d6 into master Sep 28, 2021
@glenn-jocher glenn-jocher deleted the fix/hub_root branch September 28, 2021 13:36
@glenn-jocher glenn-jocher linked an issue Sep 28, 2021 that may be closed by this pull request
CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
* Fix relative `ROOT` Pytorch Hub custom model bug

* Update yolo.py
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Fix relative `ROOT` Pytorch Hub custom model bug

* Update yolo.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant