Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope check_file() search space #4933

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Scope check_file() search space #4933

merged 1 commit into from
Sep 27, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 26, 2021

check_file() now limited to searching opt-in directories: /data, /models, /utils. This prevents large non-project directories like /.git and /venv from being searched, which may cause check_file() to slow significantly.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Refinement of file search paths to prioritize specific directories.

📊 Key Changes

  • File searching algorithm updated to focus on 'data', 'models', and 'utils' directories.
  • Explicit search paths replace the previous general glob search.

🎯 Purpose & Impact

  • Purpose: Streamline file lookup by narrowing down the search scope, reducing search time, and minimizing file ambiguity.
  • Impact: Users should experience faster and more accurate file retrieval, especially when multiple files with the same name exist in the project. The updated search method is more predictable, aiding in efficient debugging and file management. 🚀

`check_file()` now limited to searching opt-in directories: /data, /models, /utils. This prevents large non-project directories like /.git and /venv from being searched, which may cause `check_file()` to slow significantly.
@glenn-jocher glenn-jocher merged commit 5a8e434 into master Sep 27, 2021
@glenn-jocher glenn-jocher deleted the update/check_file branch September 27, 2021 00:11
CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
`check_file()` is now limited to searching opt-in directories: /data, /models, /utils. This prevents large non-project directories like /.git and /venv from being searched, which may cause `check_file()` to slow significantly.
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
`check_file()` is now limited to searching opt-in directories: /data, /models, /utils. This prevents large non-project directories like /.git and /venv from being searched, which may cause `check_file()` to slow significantly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant