Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix root referenced before assignment #4920

Merged
merged 2 commits into from
Sep 25, 2021
Merged

Fix root referenced before assignment #4920

merged 2 commits into from
Sep 25, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 25, 2021

Fix for bug introduced by #4919 discovered on VOC autodownload:

python train.py --data VOC.yaml

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Updated dataset autodownload and extraction process in check_dataset function.

πŸ“Š Key Changes

  • Ensured the root directory for unzipping datasets is defined before downloading the .zip file.
  • Improved user feedback by adding a newline character to the dataset autodownload success/failure message.

🎯 Purpose & Impact

  • These changes aim to make the dataset downloading process more robust and user-friendly.
  • Users will experience a smoother autodownload process with clearer communication on success or failure status. This can be particularly helpful when setting up datasets for the first time or in automated scripts. πŸ”„

Fix for bug introduced by #4919 discovered on VOC autodownload:
```
python train.py --data VOC.yaml
```
@glenn-jocher glenn-jocher merged commit 39c17ce into master Sep 25, 2021
@glenn-jocher glenn-jocher deleted the fix/root branch September 25, 2021 16:16
@glenn-jocher glenn-jocher self-assigned this Sep 25, 2021
CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
* Fix `root` referenced before assignment

Fix for bug introduced by ultralytics#4919 discovered on VOC autodownload:
```
python train.py --data VOC.yaml
```

* Cleanup
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Fix `root` referenced before assignment

Fix for bug introduced by ultralytics#4919 discovered on VOC autodownload:
```
python train.py --data VOC.yaml
```

* Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant