Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W&B: Fix dataset check #4879

Merged
merged 10 commits into from
Sep 21, 2021
Merged

W&B: Fix dataset check #4879

merged 10 commits into from
Sep 21, 2021

Conversation

AyushExel
Copy link
Contributor

@AyushExel AyushExel commented Sep 21, 2021 •
edited by UltralyticsAssistant
Loading

Fix for #4876

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Optimized Weights & Biases (wandb) login logic in YOLOv5's wandb_utils.py.

📊 Key Changes

  • Adjusted the placement of the RANK variable for clarity.
  • Refined the conditions for wandb login to only proceed for the main process or single-process runs.
  • Improved checks for wandb artifacts to handle different dataset formats.

🎯 Purpose & Impact

  • 🔐 Security & Stability: Restricts wandb auto-login to appropriate processes, reducing the risk of concurrent login attempts in distributed training.
  • 🧰 Enhanced Compatibility: Better handling of dataset paths now includes support for various data formats, ensuring smoother integration with wandb artifacts.
  • ✅ Code Clarity: Minor code reorganization enhances readability and maintainability.

@AyushExel AyushExel mentioned this pull request Sep 21, 2021
Closed
@glenn-jocher glenn-jocher linked an issue Sep 21, 2021 that may be closed by this pull request
AttributeError: 'list' object has no attribute 'startswith' #4876
Closed
@glenn-jocher glenn-jocher merged commit 59aae85 into ultralytics:master Sep 21, 2021
@glenn-jocher
Copy link
Member

@AyushExel PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐

CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
@AyushExel @CesarBazanAV
W&B: Fix dataset check (ultralytics#4879)
0f33bca 
* evolve fix

* Enable login timeout

* fix pkg

* check rank

* don't relogin

* fix

* reformat
@glenn-jocher glenn-jocher mentioned this pull request Oct 12, 2021
Merged
@glenn-jocher glenn-jocher mentioned this pull request Nov 7, 2021
Closed
@glenn-jocher glenn-jocher mentioned this pull request Nov 14, 2021
Merged
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
@AyushExel
W&B: Fix dataset check (ultralytics#4879)
e8ee13d 
* evolve fix

* Enable login timeout

* fix pkg

* check rank

* don't relogin

* fix

* reformat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: 'list' object has no attribute 'startswith'
2 participants
@AyushExel @glenn-jocher