Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify check_requirements() usage #4855

Merged
merged 2 commits into from
Sep 18, 2021
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 18, 2021

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced dependency checking and code simplicity in YOLOv5.

πŸ“Š Key Changes

  • πŸ”„ Simplified check_requirements() calls by no longer passing requirements.txt path explicitly.
  • πŸ›  Fixed an assert statement to use f-strings for error messages in autoanchor.py.
  • ✨ Added FILE and ROOT global variables in general.py for easier path management across modules.

🎯 Purpose & Impact

  • 🧹 Refactoring: By refining check_requirements() and using global variables for paths, the codebase is more maintainable and readable.
  • 🐞 Bug Fix: The updated assert statement in autoanchor.py ensures that error messages are displayed correctly when the expected number of anchor points are not generated.
  • πŸ€– User Experience: This update mainly affects the backend processes and contributes to a smoother experience for developers working on the YOLOv5 codebase. Regular users might notice improved stability and fewer installation issues.

@glenn-jocher glenn-jocher self-assigned this Sep 18, 2021
@glenn-jocher glenn-jocher merged commit 4c839ee into master Sep 18, 2021
@glenn-jocher glenn-jocher deleted the update/check_requirements branch September 18, 2021 16:34
CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
* Simplify `check_requirements()` usage

* remove assert, print()
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Simplify `check_requirements()` usage

* remove assert, print()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant