Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIL.ImageDraw.text(anchor=...) removal, reduce to >=7.1.2 #4842

Merged
merged 3 commits into from
Sep 17, 2021
Merged

PIL.ImageDraw.text(anchor=...) removal, reduce to >=7.1.2 #4842

merged 3 commits into from
Sep 17, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 17, 2021 •
edited by UltralyticsAssistant
Loading

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Updated dependencies and enhanced label drawing in plots.

📊 Key Changes

  • 🧩 Lowered minimum requirement for Pillow library from version 8.0.0 to 7.1.2.
  • 🎨 Modified label drawing logic in box_label function within utils/plots.py.

🎯 Purpose & Impact

  • 🔄 By lowering the Pillow version requirement, the codebase becomes compatible with environments that have older versions of Pillow installed, increasing accessibility.
  • 🖼️ The change in label drawing takes into account the height of the label when positioning it, which possibly fixes alignment issues with text labels on the bounding boxes, leading to a cleaner visual presentation in plots.

@glenn-jocher glenn-jocher changed the title Unpin Pillow PIL.ImageDraw.text(anchor=...) removal, reduce to >=7.1.2 Sep 17, 2021
@glenn-jocher
Copy link
Member Author

@kalenmike this reduces PIL dependency down to 7.1.2, which is already installed in Colab, solving our earlier problem.

This was linked to issues Sep 17, 2021
yolo v5 from pytorch hub not running on colab #4841
Closed
Colab example no longer works out of the box #4749
Closed
@glenn-jocher glenn-jocher self-assigned this Sep 17, 2021
@glenn-jocher glenn-jocher merged commit 3a822a2 into master Sep 17, 2021
@glenn-jocher glenn-jocher deleted the test/unpin_pillow branch September 17, 2021 11:02
This was referenced Sep 17, 2021
Closed
Closed
CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
@glenn-jocher @CesarBazanAV
PIL.ImageDraw.text(anchor=...) removal, reduce to >=7.1.2 (ultral…
708b150 
…ytics#4842)

* Unpin Pillow

* Update requirements.txt

* Update plots.py
@glenn-jocher glenn-jocher mentioned this pull request Oct 12, 2021
Merged
@glenn-jocher glenn-jocher mentioned this pull request Nov 7, 2021
Closed
@glenn-jocher glenn-jocher mentioned this pull request Nov 14, 2021
Merged
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
@glenn-jocher
PIL.ImageDraw.text(anchor=...) removal, reduce to >=7.1.2 (ultral…
b3b8f7e 
…ytics#4842)

* Unpin Pillow

* Update requirements.txt

* Update plots.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glenn-jocher glenn-jocher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yolo v5 from pytorch hub not running on colab Colab example no longer works out of the box
1 participant
@glenn-jocher