Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_writeable() for 3 OS support #4743

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Fix is_writeable() for 3 OS support #4743

merged 2 commits into from
Sep 10, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 10, 2021

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced the configuration directory handling and write permission checking for better cross-platform support.

πŸ“Š Key Changes

  • πŸ“ Updated user_config_dir to determine user-specific configuration directory with improved logic.
  • πŸ›  Fixed an issue with is_writeable, which now robustly checks for write permissions through a test file creation method.

🎯 Purpose & Impact

  • πŸš€ Purpose: To ensure that the application can correctly locate and use the configuration directory regardless of the operating system and environment constraints (like Google Cloud Functions or AWS Lambda).
  • πŸ’Ύ Impact: Users across different platforms should experience more reliable behavior when the software attempts to read or write configurations, with reduced chance of permissions-related errors.
  • πŸ”’ Security and Stability: The new approach in getting the write permissions helps to avoid known issues on Windows, thereby increasing security and stability for all users.

@glenn-jocher glenn-jocher merged commit a144536 into master Sep 10, 2021
@glenn-jocher glenn-jocher deleted the fix/is_writeable branch September 10, 2021 15:06
@glenn-jocher glenn-jocher self-assigned this Sep 10, 2021
CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
* Fix `is_writeable()` for 3 OS support

* Update general.py
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Fix `is_writeable()` for 3 OS support

* Update general.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant