Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_coco argument from test() #3553

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jun 9, 2021

@AyushExel I'm removing the is_coco argument from test() in test.py, we'll do the determination directly in test(). This should reduce arguments and simplify things a bit.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Streamlining the is_coco parameter across test and train scripts.

πŸ“Š Key Changes

  • Removed the is_coco parameter from the function signatures in test.py and train.py.
  • Added automatic COCO dataset detection in test.py based on the dataset's validation file path.

🎯 Purpose & Impact

  • Simplicity: Removes the need for manual specification of the is_coco flag, reducing the complexity of method calls.
  • Automation: Enhances the user experience by auto-detecting if the dataset used is COCO, which could reduce configuration errors and streamline dataset handling.
  • Potential Impact: Users no longer have to worry about a separate is_coco flag during testing and training, which simplifies the codebase and reduces potential bugs or misconfigurations.

@AyushExel
Copy link
Contributor

@glenn-jocher awesome looks good!

@glenn-jocher glenn-jocher merged commit 63157d2 into master Jun 9, 2021
@glenn-jocher glenn-jocher deleted the remove_test_iscoco_arg branch June 9, 2021 13:09
Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants