Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datasets.py #3531

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Update datasets.py #3531

merged 1 commit into from
Jun 8, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jun 8, 2021

Minor updates to #3505, inplace accumulation.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improvements to label caching in the YOLOv5 data loading process.

πŸ“Š Key Changes

  • Simplified progress bar updating in the cache_labels function by accumulating counts directly within the loop.
  • Removed unnecessary variable reassignment for image/label verification counts (missing, found, empty, corrupted).

🎯 Purpose & Impact

  • πŸš€ Enhances code readability and efficiency during the label caching step.
  • πŸ” Provides clearer real-time feedback to the user on the status of label scanning with a progressive summary (found, missing, empty, corrupted).
  • πŸ“ˆ Potentially reduces memory overhead by eliminating redundant assignments, though impact on overall performance is likely minimal.

Minor updates to #3505, inplace accumulation.
@glenn-jocher glenn-jocher self-assigned this Jun 8, 2021
@glenn-jocher glenn-jocher merged commit 8d52c1c into master Jun 8, 2021
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-4 branch June 8, 2021 16:36
Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
Minor updates to ultralytics#3505, inplace accumulation.

(cherry picked from commit 8d52c1c)
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Minor updates to ultralytics#3505, inplace accumulation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant