Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_requirements() exclude opencv-python #3507

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jun 7, 2021

Duplicate of #3495 merged to develop. This PR will be merged to master.

Fixes #3494.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced dependency checks for YOLOv5 model setup.

πŸ“Š Key Changes

  • Modified the check_requirements function call in hubconf.py.
  • Excluded opencv-python from the installation requirements check list.

🎯 Purpose & Impact

  • Purpose: Streamline the setup process by preventing unnecessary checks for opencv-python during the model's initialization. This can help avoid conflicts or issues when opencv-python is not needed for certain users.
  • Impact: Users who don't require opencv-python for their specific use cases will have a smoother setup experience with reduced chances of installation issues. The change could also potentially speed up the setup for all users, making the overall process more efficient. πŸš€

Duplicate of #3495 merged to `develop`. This PR will be merged to `master`.

Fixes #3494.
@glenn-jocher glenn-jocher linked an issue Jun 7, 2021 that may be closed by this pull request
@glenn-jocher glenn-jocher merged commit 3f03acb into master Jun 7, 2021
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-4 branch June 7, 2021 13:38
Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
Duplicate of ultralytics#3495 merged to `develop`. This PR will be merged to `master`.

Fixes ultralytics#3494.

(cherry picked from commit 3f03acb)
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Duplicate of ultralytics#3495 merged to `develop`. This PR will be merged to `master`.

Fixes ultralytics#3494.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about loading pretrained model
1 participant