Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Cython #3297

Merged
merged 1 commit into from
May 23, 2021
Merged

Comment Cython #3297

merged 1 commit into from
May 23, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 23, 2021

Ultralytics REST API fix, check_requirements fails to properly see that Cython is installed.

Screenshot 2021-05-23 at 17 45 41

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Adjustments to library requirements for YOLOv5, enhancing compatibility and calculation features.

πŸ“Š Key Changes

  • Commented out Cython: Cython is no longer a required dependency, suggesting it's an optional or indirect dependency now.
  • Reordered thop: The thop library, which is used for FLOPS (Floating Point Operations Per Second) computation, has been moved in the list but remains a requirement.

🎯 Purpose & Impact

  • Enhanced Flexibility: By making Cython an optional requirement, the YOLOv5 setup process may become more flexible, reducing the potential for installation issues related to the Cython package.
  • Better Maintainability: Reordering dependencies can sometimes be a part of cleaning up the requirements file for better readability and maintainability.
  • Minimal User Impact: These changes are minor and should not significantly impact most end-users, but developers who directly interact with the codebase may appreciate the clarified dependencies.

πŸ” Note: For users unfamiliar with these terms, "FLOPS computation" is related to measuring the performance of a model or processing system, where a higher number indicates the system can handle more calculations per second. "COCO mAP" refers to a standard metric used to evaluate object detection models based on the COCO dataset.

Ultralytics REST API fix.
@glenn-jocher glenn-jocher merged commit ee24ae1 into master May 23, 2021
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch May 23, 2021 15:53
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Ultralytics REST API fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant