Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check CoreML models.train() mode #3262

Merged
merged 2 commits into from
May 20, 2021
Merged

Check CoreML models.train() mode #3262

merged 2 commits into from
May 20, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 20, 2021 •
edited by UltralyticsAssistant
Loading

Improved error handling for #3238

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improved CoreML model export safety checks.

📊 Key Changes

  • Added an assertion to ensure CoreML exports occur only when the model is in train mode.

🎯 Purpose & Impact

  • 🛡️ Enhances the reliability of CoreML exports by preventing improper usage.
  • 🚦 Ensures users export their models in the correct mode, potentially improving the performance and accuracy of the exported models.
  • 🧑‍🔬 Helps in maintaining consistency and standards when exporting models using the script.

@glenn-jocher glenn-jocher linked an issue May 20, 2021 that may be closed by this pull request
converted core ml model doen't include classes in metadata #3238
Closed
@glenn-jocher glenn-jocher mentioned this pull request May 20, 2021
Closed
@glenn-jocher glenn-jocher merged commit 7b36e38 into master May 20, 2021
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch May 20, 2021 13:22
@glenn-jocher glenn-jocher self-assigned this May 20, 2021
Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
@glenn-jocher @Lechtr
Check CoreML models.train() mode (ultralytics#3262)
749fc5a 
* Check CoreML models.train() mode

* Update export.py

(cherry picked from commit 7b36e38)
@glenn-jocher glenn-jocher mentioned this pull request Oct 12, 2021
Merged
@glenn-jocher glenn-jocher mentioned this pull request Nov 7, 2021
Closed
@glenn-jocher glenn-jocher mentioned this pull request Nov 14, 2021
Merged
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
@glenn-jocher
Check CoreML models.train() mode (ultralytics#3262)
1ea05f9 
* Check CoreML models.train() mode

* Update export.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glenn-jocher glenn-jocher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

converted core ml model doen't include classes in metadata
1 participant
@glenn-jocher