Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0 FPS stream bug fix #3216

Merged
merged 1 commit into from
May 17, 2021
Merged

0 FPS stream bug fix #3216

merged 1 commit into from
May 17, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 17, 2021 •
edited by UltralyticsAssistant
Loading

0 FPS stream fix for #3196

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improved FPS handling for video streams in YOLOv5.

📊 Key Changes

  • Modified the method of obtaining FPS from video captures to provide a default value.

🎯 Purpose & Impact

  • 🎥 Ensures a fallback FPS of 30 when the capture FPS is incorrectly read as 0, leading to more consistent video processing.
  • 🛠️ Prevents potential division by zero errors that could arise during frame rate calculations.
  • ⏱️ Improves user experience by providing a reasonable default for video analysis tasks.

@glenn-jocher glenn-jocher linked an issue May 17, 2021 that may be closed by this pull request
Stream with 0fps? #3196
Closed
@glenn-jocher glenn-jocher self-assigned this May 17, 2021
@glenn-jocher glenn-jocher changed the title Update datasets.py 0 FPS stream bug fix May 17, 2021
@glenn-jocher glenn-jocher merged commit 13a1c72 into master May 17, 2021
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-5 branch May 17, 2021 20:24
@glenn-jocher glenn-jocher restored the glenn-jocher-patch-5 branch May 17, 2021 20:24
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-5 branch May 17, 2021 20:25
@glenn-jocher glenn-jocher mentioned this pull request May 17, 2021
Closed
Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
@glenn-jocher @Lechtr
Update datasets.py (ultralytics#3216)
2c096c1 
(cherry picked from commit 13a1c72)
@glenn-jocher glenn-jocher mentioned this pull request Oct 12, 2021
Merged
@glenn-jocher glenn-jocher mentioned this pull request Nov 7, 2021
Closed
@glenn-jocher glenn-jocher mentioned this pull request Nov 14, 2021
Merged
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
@glenn-jocher
Update datasets.py (ultralytics#3216)
617637e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glenn-jocher glenn-jocher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stream with 0fps?
1 participant
@glenn-jocher