Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent List Bug Fix #3214

Merged
merged 1 commit into from
May 17, 2021
Merged

Silent List Bug Fix #3214

merged 1 commit into from
May 17, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 17, 2021

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Optimization of the label plotting function in the YOLOv5 repository.

πŸ“Š Key Changes

  • Commented out the line of code that updates the colors for histogram patches.

🎯 Purpose & Impact

  • The purpose of this change is to address a bug identified as 'silent_list' object has no attribute 'patches'Β #3195.
  • Impact: Potential increase in plot generation performance and stability, ensuring color updates do not cause issues during histogram creation.
  • Users may notice improved reliability in label plotting visualizations. πŸ“ˆ

@glenn-jocher glenn-jocher linked an issue May 17, 2021 that may be closed by this pull request
@glenn-jocher
Copy link
Member Author

@SkalskiP this is an interesting case. I implemented #3192 earlier today, it passed all CI, but fails in Colab, now reverting in this PR after user complaints. It's probably a simple matplotlib version issue, but I was thinking it would be great to include Colab also in our CI tests is possible.

@glenn-jocher glenn-jocher merged commit ffb47ff into master May 17, 2021
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-5 branch May 17, 2021 15:47
Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'silent_list' object has no attribute 'patches'
1 participant