Update CoreML model conversion to do pixel scaling as well #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
As agreed in #133 , in order to do proper inference with a model converted to CoreML, one has to also pass pixel scaling (if there is any done).
In detect.py, there is this specified:
I have updated the CoreML model conversion step to do this as well.
Cheers
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improved CoreML model export with scaling in Ultralytics YOLOv5.
📊 Key Changes
1/255.0
with a zero bias.🎯 Purpose & Impact
detect.py
.