Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CAP_PROP_FRAME_COUNT for YouTube sources #3193

Merged
merged 1 commit into from
May 17, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 17, 2021

Possible help for stream ending fix #2769

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved video frame counting and logging in dataset handling.

πŸ“Š Key Changes

  • Variable nframes in LoadStreams class was renamed to frames for consistency.
  • Logging now includes total frame count when reading videos.

🎯 Purpose & Impact

  • 🎨 Consistency: Renaming the variable enhances code readability and maintainability.
  • 🧾 Enhanced Logging: Users get more detailed video information (total frame count), improving the debugging process and user experience.

@glenn-jocher glenn-jocher linked an issue May 17, 2021 that may be closed by this pull request
@glenn-jocher glenn-jocher self-assigned this May 17, 2021
@glenn-jocher glenn-jocher mentioned this pull request May 17, 2021
@glenn-jocher glenn-jocher merged commit 36b0a9e into master May 17, 2021
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-5 branch May 17, 2021 10:27
Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do you end a stream on detect.py?
1 participant