Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yolov5/__init__.py #3127

Merged
merged 1 commit into from
May 12, 2021
Merged

Add yolov5/__init__.py #3127

merged 1 commit into from
May 12, 2021

Conversation

KC-Zhang
Copy link
Contributor

@KC-Zhang KC-Zhang commented May 11, 2021

add an empty init.py in the base folder.

This way, the yolov5 folder can be installed as a package within our own projects as a git-submodule, and install everything using a setup.py. Since it is not clean to modify contents of a submodule (including adding init.py), it's better if the repo already has init.py.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Introducing a new initial file setup for the ultralytics/yolov5 project.

📊 Key Changes

  • A new __init__.py file has been added to the repository.

🎯 Purpose & Impact

  • The addition of the __init__.py file signals that the directory it resides in is a Python package, allowing for its modules to be easily imported elsewhere in the project or by other Python projects.
  • This change could potentially improve the modularity and portability of the YOLOv5 codebase, making it more user-friendly for developers who need to integrate YOLOv5 into their own projects. 🔄
  • Users and developers may also experience a more structured project, which could enhance code organization and clarity. 📁

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @KC-Zhang, thank you for submitting a 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify your PR is up-to-date with origin/master. If your PR is behind origin/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature  # <----- replace 'feature' with local branch name
git rebase upstream/master
git push -u origin -f
  • ✅ Verify all Continuous Integration (CI) checks are passing.
  • ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee

@fcakyon
Copy link
Member

fcakyon commented May 12, 2021

@KC-Zhang You can utilize torch hub or use this pypi package for this purpose.

@glenn-jocher
Copy link
Member

@KC-Zhang PR is passing CI, we'll try out your init. Thank you for your contributions!

@glenn-jocher glenn-jocher changed the title add init Add yolov5/__init__.py May 12, 2021
@glenn-jocher glenn-jocher linked an issue May 12, 2021 that may be closed by this pull request
@glenn-jocher glenn-jocher merged commit bd6f6a7 into ultralytics:master May 12, 2021
@glenn-jocher glenn-jocher mentioned this pull request May 12, 2021
Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add __init__.py
3 participants