Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect.py streaming source --save-crop bug fix #3102

Merged
merged 2 commits into from
May 10, 2021
Merged

detect.py streaming source --save-crop bug fix #3102

merged 2 commits into from
May 10, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 10, 2021 •
edited by UltralyticsAssistant
Loading

Possible fix for #3100.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced 'save_crop' functionality in YOLOv5's detect module.

📊 Key Changes

  • Introduction of an option to make a copy of the original image im0 if save_crop is enabled.
  • Modification of save_one_box to use the copied image imc instead of im0s when saving cropped images.

🎯 Purpose & Impact

  • Purpose: These changes aim to preserve the original image for cropping so that the saved crop is unaffected by any drawing or annotations made on the detection output (im0).
  • Impact: Users now have the ability to save cleaner cropped images without any overlaid drawings if they choose to do so, enhancing the usefulness of the crops for further analysis or usage.

@glenn-jocher glenn-jocher linked an issue May 10, 2021 that may be closed by this pull request
--save-crop from youtube error #3100
Closed
@glenn-jocher glenn-jocher merged commit 25f8ab8 into master May 10, 2021
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-5 branch May 10, 2021 14:39
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
@glenn-jocher
detect.py streaming source --save-crop bug fix (ultralytics#3102)
1692a34 
* detect.py streaming source --save-crop bug fix

Possible fix for ultralytics#3100.

* () parenthesis
Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
@glenn-jocher @Lechtr
detect.py streaming source --save-crop bug fix (ultralytics#3102)
7168572 
* detect.py streaming source --save-crop bug fix

Possible fix for ultralytics#3100.

* () parenthesis

(cherry picked from commit 25f8ab8)
@glenn-jocher glenn-jocher mentioned this pull request Oct 12, 2021
Merged
@glenn-jocher glenn-jocher mentioned this pull request Nov 7, 2021
Closed
@glenn-jocher glenn-jocher mentioned this pull request Nov 14, 2021
Merged
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
@glenn-jocher
detect.py streaming source --save-crop bug fix (ultralytics#3102)
2464044 
* detect.py streaming source --save-crop bug fix

Possible fix for ultralytics#3100.

* () parenthesis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--save-crop from youtube error
1 participant
@glenn-jocher