Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #3042 #3058

Merged
merged 1 commit into from
May 7, 2021
Merged

Fixed #3042 #3058

merged 1 commit into from
May 7, 2021

Conversation

kepler62f
Copy link
Contributor

@kepler62f kepler62f commented May 7, 2021

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improving code comments for clarity in the test script.

πŸ“Š Key Changes

  • Updated the comments within the test loop to correctly label ti as target indices and pi as prediction indices.

🎯 Purpose & Impact

  • πŸ’‘ Purpose: The modification aims to make comments in the code clearer, preventing confusion about what ti and pi variables represent.
  • πŸš€ Impact: This change enhances code readability and maintainability, making it easier for developers to understand and collaborate. It has no impact on functionality or performance for the end user.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘‹ Hello @kepler62f, thank you for submitting a πŸš€ PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • βœ… Verify your PR is up-to-date with origin/master. If your PR is behind origin/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature  # <----- replace 'feature' with local branch name
git rebase upstream/master
git push -u origin -f
  • βœ… Verify all Continuous Integration (CI) checks are passing.
  • βœ… Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee

@glenn-jocher
Copy link
Member

@kepler62f PR looks good, merging. Thank you for your contributions!

@glenn-jocher glenn-jocher linked an issue May 7, 2021 that may be closed by this pull request
@glenn-jocher glenn-jocher merged commit f2de1ad into ultralytics:master May 7, 2021
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
Co-authored-by: kepler62f <>
danny-schwartz7 pushed a commit to danny-schwartz7/yolov5 that referenced this pull request May 22, 2021
Co-authored-by: kepler62f <>
Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
Co-authored-by: kepler62f <>
(cherry picked from commit f2de1ad)
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Co-authored-by: kepler62f <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about calculating mAP at test time
2 participants