Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyTorch Hub cv2 .save() .show() bug fix #2831

Merged
merged 3 commits into from
Apr 18, 2021
Merged

PyTorch Hub cv2 .save() .show() bug fix #2831

merged 3 commits into from
Apr 18, 2021

Commits on Apr 18, 2021

  1. PyTorch Hub cv2 .save() .show() bug fix 

    cv2.rectangle() was failing on non-contiguous np array inputs. This checks for contiguous arrays and applies is necessary:
```python
imgs[i] = im if im.data.contiguous else np.ascontiguousarray(im)  # update
```
    @glenn-jocher
    glenn-jocher committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    429ab71 View commit details
    Browse the repository at this point in the history

  2. Update plots.py 

    ```python
assert im.data.contiguous, 'Image not contiguous. Apply np.ascontiguousarray(im) to plot_on_box() input image.'
```
    @glenn-jocher
    glenn-jocher committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    07506fe View commit details
    Browse the repository at this point in the history

  3. Update hubconf.py 

    Expand CI tests to OpenCV image.
    @glenn-jocher
    glenn-jocher committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    5997f77 View commit details
    Browse the repository at this point in the history