Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_git_status() when not exist /workspace #1966

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 17, 2021

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved detection of Docker environments in the YOLOv5 repository codebase. 🐳

πŸ“Š Key Changes

  • Changed the detection method for Docker environments from checking for /.dockerenv to checking for /workspace.

🎯 Purpose & Impact

  • Purpose: The adjustment ensures that the Git status check does not incorrectly recommend a git pull when the code is running inside a Docker container that does not have a /.dockerenv file but uses a different marker, such as /workspace.
  • Potential Impact: This change likely improves user experience by preventing unnecessary update prompts for Docker users and aligns with various popular Docker environment setups. It ensures the repository code behaves as expected across different Docker configurations. πŸš€

@glenn-jocher glenn-jocher merged commit b26a2f6 into master Jan 17, 2021
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-2 branch January 17, 2021 19:55
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
taicaile pushed a commit to taicaile/yolov5 that referenced this pull request Oct 12, 2021
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant