Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub API rate limit fallback #1930

Merged
merged 1 commit into from
Jan 14, 2021
Merged

GitHub API rate limit fallback #1930

merged 1 commit into from
Jan 14, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 14, 2021

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced flexibility in downloading model files from custom repositories.

πŸ“Š Key Changes

  • πŸ”„ Updated the attempt_download function to allow for specifying a custom GitHub repository.
  • πŸ›  Added a fallback mechanism that defaults to a predefined asset list and uses the last git tag in case the GitHub API call fails.
  • πŸ“‘ Included a dynamic repository URL for storage bucket downloads, aligning with the new custom repo feature.

🎯 Purpose & Impact

  • πŸš€ Purpose: This change allows users to download model files from different GitHub repositories, not just the default ultralytics/yolov5. It also provides a robust fallback for download attempts if the GitHub API request fails.
  • ✨ Impact: Users and developers can work with models across various repositories, increasing modularity and collaboration opportunities. Moreover, the fallback ensures model downloads are less likely to fail, improving the reliability of model setup processes.

@glenn-jocher glenn-jocher merged commit b75c432 into master Jan 14, 2021
@glenn-jocher glenn-jocher deleted the fix branch January 14, 2021 05:09
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
taicaile pushed a commit to taicaile/yolov5 that referenced this pull request Oct 12, 2021
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant