Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete .github/workflows/greetings.yml #13309

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

UltralyticsAssistant
Copy link
Member

@UltralyticsAssistant UltralyticsAssistant commented Sep 12, 2024

This PR deletes the .github/workflows/greetings.yml file.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Streamlined GitHub workflows to enhance user engagement and support.

πŸ“Š Key Changes

  • Integrated a new response feature in format.yml for greeting issue authors with helpful resources.
  • Removed the outdated greetings.yml workflow file.

🎯 Purpose & Impact

  • πŸŽ‰ Enhanced User Experience: Automatically provides users with resources, reducing response time for common queries.
  • πŸš€ Promotes Latest Features: Highlights YOLOv8, ensuring users are informed about the latest advancements.
  • πŸ”„ Maintenance Improvement: Simplifies workflow management by removing redundant files, ensuring cleaner and more efficient processes.

@UltralyticsAssistant UltralyticsAssistant added the enhancement New feature or request label Sep 12, 2024
@UltralyticsAssistant
Copy link
Member Author

πŸš€ PR Review

Hello @UltralyticsAssistant! Thank you for your contribution to the YOLOv5 repository. Your PR focuses on simplifying the repository by removing the automated greetings workflow from GitHub Actions.

πŸ” Key Details

  • File Removed: .github/workflows/greetings.yml
  • Purpose: Streamlines communication by eliminating automated welcome messages for new PRs and issues.

πŸ“‹ Best Practices for PR Submissions

To ensure smooth integration and review of your PRs, here are some best-practice guidelines:

  1. Keep Your Branch Updated: Ensure your PR branch is up-to-date with the ultralytics/yolov5 master branch. You can do this by merging the latest changes from master into your feature branch:

    git checkout master
    git pull
    git checkout your-feature-branch
    git merge master
  2. Pass All Checks: Make sure all Continuous Integration (CI) checks pass before submitting your PR. This includes tests for training, validation, and more.

  3. Minimize Changes: Focus your PR on specific bug fixes or feature additions, keeping changes to the necessary minimum. This helps reviewers understand and merge your contributions more easily.

  4. Documentation: If your PR involves major changes or additions, consider updating necessary documentation to help users understand new features or modifications.

πŸ‘€ Next Steps

A human reviewer will review your PR soon to provide additional feedback or approve the changes. If you have any questions or need further assistance, feel free to ask.

Thank you once again for your contribution to improving YOLOv5! 😊

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit f732292 into master Sep 12, 2024
7 checks passed
@glenn-jocher glenn-jocher deleted the delete-greetings-1726161022 branch September 12, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants