-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ONNXSim with ONNXSlim #13236
Conversation
Signed-off-by: Kayzwer <68285002+Kayzwer@users.noreply.github.com>
@inisis done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Hello @Kayzwer, thank you for submitting a YOLOv5 π PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- β
Verify your PR is up-to-date with
ultralytics/yolov5
master
branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pull
andgit merge master
locally. - β Verify all YOLOv5 Continuous Integration (CI) checks are passing.
- β Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β Bruce Lee
@Kayzwer thank you bro |
Hi @glenn-jocher , can this be merged, it' was tested in ultralytics |
Hi @inisis, Thank you for your contribution! It's great to hear that you've tested this in Ultralytics. Before we proceed with merging, could you please ensure that the changes are compatible with the latest versions of the dependencies and that all tests pass successfully? This helps us maintain stability and reliability for all users. If everything checks out, we'll be happy to review and merge your PR. Thanks again for your efforts and for contributing to the YOLO community! π |
@glenn-jocher I believe all the CI tests are passed π |
Hi @inisis, That's fantastic news! π Thank you for running the CI tests and confirming that they have passed. This is a crucial step in ensuring the stability and reliability of the changes. We'll proceed with a final review of your PR. If everything looks good, we'll merge it shortly. Your contribution is greatly appreciated and will benefit the entire YOLO community. Thanks again for your hard work and dedication! |
π οΈ PR Summary
Made with β€οΈ by Ultralytics Actions
π Summary
This PR replaces the ONNX model simplifier with a newer slim tool for better model optimization.
π Key Changes
onnx-simplifier
withonnxslim
for model optimization.onnxslim
package.onnxslim
.π― Purpose & Impact