Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ONNXSim with ONNXSlim #13236

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

Kayzwer
Copy link
Contributor

@Kayzwer Kayzwer commented Jul 31, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

This PR replaces the ONNX model simplifier with a newer slim tool for better model optimization.

πŸ“Š Key Changes

  • πŸ“ Replaced onnx-simplifier with onnxslim for model optimization.
  • πŸ“ˆ Updated the requirement checks for the onnxslim package.
  • πŸŽ‰ Adjusted log messages to reflect the use of onnxslim.

🎯 Purpose & Impact

  • βž• Purpose: To use a more efficient and potentially more reliable tool (onnxslim) for optimizing ONNX models.
  • πŸ’Ό Impact: Users may experience faster and more reliable model optimization, leading to better performance in deployments.

Signed-off-by: Kayzwer <68285002+Kayzwer@users.noreply.github.com>
@Kayzwer
Copy link
Contributor Author

Kayzwer commented Jul 31, 2024

@inisis done

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘‹ Hello @Kayzwer, thank you for submitting a YOLOv5 πŸš€ PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • βœ… Verify your PR is up-to-date with ultralytics/yolov5 master branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • βœ… Verify all YOLOv5 Continuous Integration (CI) checks are passing.
  • βœ… Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

@UltralyticsAssistant UltralyticsAssistant added dependencies Pull requests that update a dependency file enhancement New feature or request python Pull requests that update Python code labels Jul 31, 2024
@inisis
Copy link
Contributor

inisis commented Jul 31, 2024

@Kayzwer thank you bro

@inisis
Copy link
Contributor

inisis commented Aug 3, 2024

Hi @glenn-jocher , can this be merged, it' was tested in ultralytics

@glenn-jocher
Copy link
Member

Hi @inisis,

Thank you for your contribution! It's great to hear that you've tested this in Ultralytics. Before we proceed with merging, could you please ensure that the changes are compatible with the latest versions of the dependencies and that all tests pass successfully? This helps us maintain stability and reliability for all users.

If everything checks out, we'll be happy to review and merge your PR. Thanks again for your efforts and for contributing to the YOLO community! 😊

@inisis
Copy link
Contributor

inisis commented Aug 3, 2024

@glenn-jocher I believe all the CI tests are passed 😊

@glenn-jocher
Copy link
Member

Hi @inisis,

That's fantastic news! πŸŽ‰ Thank you for running the CI tests and confirming that they have passed. This is a crucial step in ensuring the stability and reliability of the changes.

We'll proceed with a final review of your PR. If everything looks good, we'll merge it shortly. Your contribution is greatly appreciated and will benefit the entire YOLO community.

Thanks again for your hard work and dedication!

@glenn-jocher glenn-jocher changed the title replacing onnxsim with onnxslim Replace ONNXSim with ONNXSlim Aug 11, 2024
@glenn-jocher glenn-jocher merged commit 19ce902 into ultralytics:master Aug 11, 2024
9 checks passed
@glenn-jocher
Copy link
Member

@Kayzwer @inisis PR merged! Thank you for your contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants