Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify default value of stride to 64 in the function letterbox #13150

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

TommeyChang
Copy link

@TommeyChang TommeyChang commented Jun 29, 2024

When the default value of stride is 32, it confronts an error when the width or height of the image is resized to 864.
I fix the bug from setting the stride to 64. Thus, I suggest to change the default value.


I have read the CLA Document and I sign the CLA

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Small update to the image preprocessing in YOLOv5 to allow more flexible stride options.

πŸ“Š Key Changes

  • Modified the letterbox function's stride parameter from a default of 32 to 64.

🎯 Purpose & Impact

  • Improved Flexibility: By increasing the default stride value, images can be resized and padded with more flexible stride options.
  • Potential Performance Impact: This may affect model inference times or performance based on how images are processed, possibly improving efficiency for certain applications.
  • User Convenience: Users may experience improved outcomes in training and inference without needing to manually adjust stride settings.

Overall, this change aims to optimize image preprocessing, benefiting both developers and end-users by making the model slightly more adaptable and efficient. πŸ“ˆβœ¨

Copy link
Contributor

github-actions bot commented Jun 29, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I sign the CLA


1 out of 2 committers have signed the CLA.
βœ… (UltralyticsAssistant)[https://github.com/UltralyticsAssistant]
❌ @TommeyChang
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants