Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the output dir in dataloaders.py #12771

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

ya0guang
Copy link
Contributor

@ya0guang ya0guang commented Feb 27, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved directory naming for file exports in data preprocessing.

πŸ“Š Key Changes

  • Changed the output directory for certain image exports from "classifier" to "classification".

🎯 Purpose & Impact

  • 🎨 Enhances clarity and consistency in directory naming conventions.
  • πŸ—‚ May affect scripts or users expecting the old "classifier" directory, requiring updates to accommodate the new "classification" path.
  • πŸ”„ Users should find it more intuitive to locate and manage exported image data tied to classification tasks.

Signed-off-by: Hongbo <12580159+ya0guang@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘‹ Hello @ya0guang, thank you for submitting a YOLOv5 πŸš€ PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • βœ… Verify your PR is up-to-date with ultralytics/yolov5 master branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • βœ… Verify all YOLOv5 Continuous Integration (CI) checks are passing.
  • βœ… Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

@glenn-jocher glenn-jocher changed the title [bugfix] Correct the output dir in dataloaders.py Correct the output dir in dataloaders.py Mar 1, 2024
@glenn-jocher glenn-jocher merged commit b939236 into ultralytics:master Mar 1, 2024
9 checks passed
@glenn-jocher
Copy link
Member

@ya0guang thank you for the PR!

NagatoYuki0943 added a commit to NagatoYuki0943/yolov5-ultralytics that referenced this pull request Mar 2, 2024
Correct the output dir in dataloaders.py (ultralytics#12771)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants