Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete .pre-commit-config.yaml #12578

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Delete .pre-commit-config.yaml #12578

merged 2 commits into from
Jan 3, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 3, 2024

Thank you πŸ™ for your contribution to Ultralytics πŸš€! Your effort in enhancing our repositories is greatly appreciated. To streamline the process and assist us in integrating your Pull Request (PR) effectively, please follow these steps:

  1. Check for Existing Contributions: Before submitting, kindly explore existing PRs to ensure your contribution is unique and complementary.

  2. Link Related Issues: If your PR addresses an open issue, please link it in your submission. This helps us better understand the context and impact of your contribution.

  3. Elaborate Your Changes: Clearly articulate the purpose of your PR. Whether it's a bug fix or a new feature, a detailed description aids in a smoother integration process.

  4. Ultralytics Contributor License Agreement (CLA): To uphold the quality and integrity of our project, we require all contributors to sign the CLA. Please confirm your agreement by commenting below:

    I have read the CLA Document and I hereby sign the CLA

For more detailed guidance and best practices on contributing, refer to our βœ… Contributing Guide. Your adherence to these guidelines ensures a faster and more effective review process.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Removed pre-commit and project-wide configuration files.

πŸ“Š Key Changes

  • Deleted .pre-commit-config.yaml, a configuration file for pre-commit hooks.
  • Removed setup.cfg, which contained settings for various tools including flake8 and pytest.

🎯 Purpose & Impact

  • The removal of these files simplifies the project's setup, potentially making it easier for new contributors to get started.
  • It could imply a change in how code quality and formatting are enforced or automated, possibly shifting towards other methods.
  • This change may affect developers who rely on these specific configurations for code consistency checks when contributing to the repository.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit c42aba5 into master Jan 3, 2024
6 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch January 3, 2024 10:36
pleb631 pushed a commit to pleb631/yolov5 that referenced this pull request Jan 6, 2024
* Delete .pre-commit-config.yaml

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Delete setup.cfg

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

---------

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant