Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci-testing.yml #12404

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Update ci-testing.yml #12404

merged 2 commits into from
Nov 20, 2023

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 20, 2023

πŸ€–[deprecated] Generated by Copilot at 583fc0a

Summary

πŸπŸ†™πŸ§ͺ

The pull request enhances the ci-testing workflow by using Python 3.9 and a custom env-check.py script. This helps to ensure the code works well across different platforms and environments.

Sing, O Muse, of the ci-testing workflow
That the skillful coder updated with care
To use the latest Python, swift and true
And a custom script for checks, clear and fair

Walkthrough

  • Update python-version to 3.11 in the matrix to test the latest Python release candidate (link, link)
  • Replace python --version with yolo checks to perform and print various environment checks (link, link)
  • Remove redundant commands python -c "import utils; utils.notebook_init()" and echo (link)

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Update to CI testing with YOLO checks and dropping automated README translation.

πŸ“Š Key Changes

  • Updated Python version in CI from 3.10 to 3.11.
  • Simplified steps in CI by replacing individual Python and pip version checks with a consolidated yolo checks command.
  • Removed the GitHub Action workflow for automatically translating the README to Chinese.

🎯 Purpose & Impact

  • The Python version update ensures compatibility and performance with the latest Python release.
  • Consolidation of checks provides cleaner and more maintainable workflow files 🧹.
  • Removing the automated README translation may reduce maintenance overhead, but also removes the convenience of automatic translation updates 🌐. Users may need to find translations manually or contribute them as needed.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit 45147c0 into master Nov 20, 2023
9 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch November 20, 2023 19:50
pleb631 pushed a commit to pleb631/yolov5 that referenced this pull request Jan 6, 2024
* Update ci-testing.yml

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Delete .github/workflows/translate-readme.yml

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

---------

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant