Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links.yml #12319

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Update links.yml #12319

merged 2 commits into from
Nov 3, 2023

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 3, 2023

πŸ€– Generated by Copilot at 6c887ca

Summary

πŸ›πŸš€πŸ”§

Improved link checking workflow by filtering out non-404 errors and correcting exclusion pattern in .github/workflows/links.yml.

To check links without too much noise
We modified the links.yml file
We fixed a typo
And only report 404
To make the workflow more precise and agile

Walkthrough

  • Filter out only 404 errors when checking links (link)
  • Fix typo in link exclusion pattern (link)

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improvement to the Continuous Integration (CI) process by refining the broken link checker behavior.

πŸ“Š Key Changes

  • πŸ›  Updated the broken link checker GitHub Action to ignore additional HTTP statuses to reduce false positives.
  • 🚫 Added status codes 403 (OpenVINO, 'forbidden'), 500 (Zenodo, 'cached'), and 502 (Zenodo, 'bad gateway') to the ignore list, in addition to pre-existing 429 (Instagram, 'too many requests') and 999 (LinkedIn, 'unknown status code').

🎯 Purpose & Impact

  • 🎯 The purpose is to prevent the CI from failing due to false positives related to known service behaviors that aren't broken links.
  • βœ… This will result in a more accurate and reliable CI process, ensuring that real issues are highlighted without being buried under falsely identified link issues.
  • 🌐 For users, this change should mean a cleaner and more trustworthy report about the health of links in the project's documentation.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit 61473c3 into master Nov 3, 2023
7 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch November 3, 2023 15:02
pleb631 pushed a commit to pleb631/yolov5 that referenced this pull request Jan 6, 2024
* Update links.yml

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Update links.yml

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

---------

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant