Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude url.com and gstatic.com from links.yml #12263

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Oct 21, 2023

πŸ€– Generated by Copilot at 4c0ac66

Summary

πŸ› οΈπŸŒπŸš«

Updated link checker workflow to reduce false positives. Added some domains to the --exclude option of lychee in .github/workflows/links.yml.

To check links we use lychee
But some domains are quite tricky
They make the workflow fail
With errors that prevail
So we ignore them and hope they're not icky

Walkthrough

  • Exclude fonts.gstatic.com and url.com domains from link checker to avoid false positives (link, link)

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved link verification workflow to exclude additional URLs.

πŸ“Š Key Changes

  • Added fonts.gstatic.com to the list of exclusions for link checking in the project's documentation and code files.
  • Ensured consistency in what URLs to exclude during link checks for different file types.

🎯 Purpose & Impact

  • Purpose: To prevent the link checker from flagging fonts.gstatic.com (a common source for Google Fonts) as an issue, which helps to reduce false positives in link verification checks.
  • Impact: Streamlines the CI process by reducing manual oversight needed for link verification results, allowing developers and contributors to focus on actual problems rather than sifting through irrelevant flags. This enhances the maintainability of the project documentation and codebase. πŸ› οΈβœ…

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit 4d687c8 into master Oct 21, 2023
8 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch October 21, 2023 16:07
NagatoYuki0943 added a commit to NagatoYuki0943/yolov5-ultralytics that referenced this pull request Oct 23, 2023
Exclude url.com and gstatic.com from links.yml (ultralytics#12263)
pleb631 pushed a commit to pleb631/yolov5 that referenced this pull request Jan 6, 2024
* Exclude url.com and gstatic.com from links.yml

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Update links.yml

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

---------

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant