Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move generated *.json annotations into runs/test #1209

Merged
merged 2 commits into from
Oct 25, 2020
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Oct 25, 2020

This PR moves prediction annotation json files into new runs/test directory on pycocotools testing.

Screenshot 2020-10-25 at 18 05 56

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved JSON file handling and naming in YOLOv5 testing script.

πŸ“Š Key Changes

  • Changed how the JSON detection results file is named when saving.
  • Updated the file handling to accommodate different types (list, str, None) of the weights parameter.
  • Simplified the result file path construction using Path from pathlib.
  • Ensured the loadRes method receives the proper string file path.

🎯 Purpose & Impact

  • 🎨 Enhances consistency in file naming for easier identification and organization of output files.
  • πŸ›  Fixes potential issues with file paths when weights parameter varies in type, improving robustness.
  • πŸ“ˆ May facilitate better integration with other tools and post-processing due to standardized file naming.
  • πŸ‘₯ Affects users who save JSON detections, making their workflow smoother and their outputs more predictable.

@glenn-jocher glenn-jocher merged commit d3dad42 into master Oct 25, 2020
@glenn-jocher glenn-jocher deleted the json_dir branch October 25, 2020 17:19
burglarhobbit pushed a commit to burglarhobbit/yolov5 that referenced this pull request Jan 1, 2021
* Move generated *.json annotations into runs/test

* list and string robust
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
* Move generated *.json annotations into runs/test

* list and string robust
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Move generated *.json annotations into runs/test

* list and string robust
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant