Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links.yml #11978

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Update links.yml #11978

merged 1 commit into from
Aug 12, 2023

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Aug 12, 2023

🤖 Generated by Copilot at f07fa5d

Summary

🔗🚫🔒

Updated link checking workflow to skip linkedin.com links. This prevents false positives from links that need login or have limits.

To check links we use lychee
But some sites are not so easy
They need a login
Or throttle our pinging
So we ignore links to linkedin

Walkthrough

  • Exclude linkedin.com links from link checking to avoid false positives (link, link)
  • Use lychee command to check links in Markdown and HTML files (link)
  • Use lychee command to check links in all file types, including YAML, Python and Notebook files (link)

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced link checking exclusions in GitHub Actions workflow.

📊 Key Changes

  • Updated lychee link checker command to exclude LinkedIn URLs.
  • Ensured consistency in lychee command across different jobs.

🎯 Purpose & Impact

  • 🎨 Improved Accuracy: By excluding LinkedIn URLs, which often return false positives due to login requirements, the accuracy of the link checking process is enhanced.
  • 🛠️ Maintenance Efficiency: More consistent workflows across different checks reduce potential errors and simplify maintenance.
  • 🚀 User Experience: Indirectly affects users by ensuring that only truly broken links are flagged, allowing contributors to focus on actual issues.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit dd10481 into master Aug 12, 2023
8 checks passed
@glenn-jocher glenn-jocher deleted the links_ci branch August 12, 2023 09:40
NagatoYuki0943 added a commit to NagatoYuki0943/yolov5-ultralytics that referenced this pull request Aug 14, 2023
pleb631 pushed a commit to pleb631/yolov5 that referenced this pull request Jan 6, 2024
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant