Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.cfg #11814

Merged
merged 6 commits into from
Jul 4, 2023
Merged

Update setup.cfg #11814

merged 6 commits into from
Jul 4, 2023

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jul 4, 2023

πŸ€– Generated by Copilot at e8aefd9

Summary

πŸ“¦πŸŽ¨πŸ“œ

Updated setup.cfg to improve packaging and code style. Used license_files to include multiple licenses, removed some flake8 error codes, and aligned with black formatting.

Oh we're the coders of the sea, and we like our code to be
Neat and tidy as can be, with black and flake8
We've updated our setup.cfg, to follow the latest decree
We've added license files galore, and a comma before the door

Walkthrough

  • Update setup.cfg to follow new packaging guidelines and improve code quality (link, link, link)

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

This PR introduces improvements to the formatting, code organization, and configuration files in the YOLOv5 codebase.

πŸ“Š Key Changes

  • Disabled the check-yaml pre-commit hook.
  • Removed --py37-plus argument from the pyupgrade pre-commit hook.
  • Added commented-out repositories yesqa and dead for potential future use in pre-commit hooks.
  • Introduced minor code formatting changes for consistency (such as adding spaces after commas in lists).
  • Modified import statements in models/yolo.py to include # noqa to ignore specific linting warnings.
  • Updated set_logging() function to use new dictionary formatting.
  • Changed check_suffix() to use a tuple with an empty space after the comma for consistency.
  • Updated setup.cfg to use license_files instead of license_file and to include additional configurations for flake8.

🎯 Purpose & Impact

  • πŸ“ The pre-commit configuration changes aim to streamline the commit process and prepare for codebase quality improvements by including placeholders for additional checks.
  • 🧹 Code formatting adjustments improve readability and maintain a consistent style throughout the codebase.
  • πŸš€ Import changes and logging improvements will help developers to troubleshoot and maintain cleaner code, potentially resulting in fewer bugs.
  • πŸ›  The setup.cfg changes officially recognize the license file and refine code style rules, which could help new contributors adhere to project standards more easily.

glenn-jocher and others added 6 commits July 5, 2023 00:38
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit 459dd49 into master Jul 4, 2023
7 checks passed
@glenn-jocher glenn-jocher deleted the precommit branch July 4, 2023 22:42
bandakopi pushed a commit to irajcode/yolov5 that referenced this pull request Jul 20, 2023
* Update setup.cfg

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update .pre-commit-config.yaml

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Update export.py

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Update downloads.py

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Update yolo.py

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

---------

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
pleb631 pushed a commit to pleb631/yolov5 that referenced this pull request Jan 6, 2024
* Update setup.cfg

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update .pre-commit-config.yaml

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Update export.py

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Update downloads.py

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Update yolo.py

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

---------

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant