Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding --save-conf to test.py and detect.py #1175

Closed

Conversation

ghost
Copy link

@ghost ghost commented Oct 20, 2020

  1. Adding --save-conf option to detect.py and test.py
  2. Adding --output option to test.py
    3 Honoring --save-txtoption intest.py`

Inspired by: #994

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Added options to save detection confidences in output text files and to specify custom output directories during testing.

πŸ“Š Key Changes

  • πŸ”§ Introduced a save_conf argument to include confidence scores in saved text files.
  • πŸ’Ύ Added output command-line argument to specify a custom output directory for results.
  • πŸ›  Modified the text file saving logic to accommodate confidence scores if save_conf is enabled.
  • πŸ“‚ Changed the default output path to be within a provided save_dir.

🎯 Purpose & Impact

  • πŸ“ˆ Enhanced flexibility: Users can now save detection confidences, aiding in better analysis and post-processing.
  • πŸ—‚ Custom output organization: The ability to set a custom output directory helps users keep their results organized.
  • πŸŽ› More control for users: These updates give users greater control over the testing output, which can be useful for various applications and workflows.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @oboiko-chegg, thank you for submitting a PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • Verify your PR is up-to-date with origin/master. If your PR is behind origin/master update by running the following, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature  # <----- replace 'feature' with local branch name
git rebase upstream/master
git push -u origin -f
  • Verify all Continuous Integration (CI) checks are passing.
  • Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee

@glenn-jocher
Copy link
Member

@oboiko-chegg thanks for the PR. By coincidence I just updated and merged PR #994 today. This means there will be a conflict with detect.py, and also that these #1175 additions will have a different implementation.

Can you update this PR here to conform to the new format as shown in #994? Thanks! https://github.com/ultralytics/yolov5/pull/994/files

@ghost
Copy link
Author

ghost commented Oct 20, 2020

I will close this one and open a new one

@ghost ghost closed this Oct 20, 2020
@olehb olehb deleted the feature/put_confidence_score_in_txt branch October 20, 2020 15:58
@olehb olehb restored the feature/put_confidence_score_in_txt branch October 20, 2020 15:58
@olehb olehb deleted the feature/put_confidence_score_in_txt branch October 20, 2020 16:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant