Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links.yml with 301,302 #11517

Merged
merged 5 commits into from
May 11, 2023
Merged

Update links.yml with 301,302 #11517

merged 5 commits into from
May 11, 2023

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 11, 2023

πŸ€– Generated by Copilot at c47ac8a

Summary

πŸ“πŸ› οΈπŸŽ¨

Fix broken links in README.md and improve YAML formatting in .github/workflows/links.yml

README.md fixed
Broken links no more, also
Blank line for YAML

Walkthrough

  • Fix broken links in README.md file (- - - - - - - - - - - - - - 0- - F0

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced link checking robustness in CI workflows

πŸ“Š Key Changes

  • Modified the lychee link check command options in the repository's continuous integration (CI) workflow files.
  • Added HTTP status codes 301 (Moved Permanently) and 302 (Found) to the acceptance list for link checks.

🎯 Purpose & Impact

  • 🎨 The change aims to reduce false positives when checking links, by recognizing HTTP redirects (301 and 302) as successful link states.
  • πŸš€ This improvement could streamline development and maintenance workflows, ensuring that redirects do not trigger unnecessary alerts or failures in the CI process.
  • πŸ”— Users and developers will experience a more benign CI report regarding the link health in the documentation, which now acknowledges web redirects as non-issues.

glenn-jocher and others added 4 commits May 11, 2023 18:37
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher changed the title Update links.yml with 302 Update links.yml with 301,302 May 11, 2023
@glenn-jocher glenn-jocher merged commit e382d4c into master May 11, 2023
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch May 11, 2023 16:51
bandakopi pushed a commit to irajcode/yolov5 that referenced this pull request Jul 20, 2023
* Update links.yml with 302

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Update links.yml

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update links.yml

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

---------

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant