Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Slack notification #11458

Merged
merged 3 commits into from
Apr 29, 2023
Merged

Improve Slack notification #11458

merged 3 commits into from
Apr 29, 2023

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Apr 29, 2023

πŸ€– Generated by Copilot at b5c041c

Summary

β™»οΈπŸ’¬βŽ

Refactor slack notification logic in ci-testing.yml workflow. Add a new job to send one message on failure instead of multiple messages from each job.

Sing, O Muse, of the cunning refactorer
Who tamed the slack notification logic
In the ci-testing.yml workflow of code
And made it simpler and more efficient.

Walkthrough

  • Consolidate slack notification logic into one job called NotifyFailure (link). This job runs after all the other jobs in the workflow and checks their status using the needs and if keywords. If any of the previous jobs failed, it sends a single message to the slack channel with the workflow name, run number, and commit SHA. This avoids duplicate notifications for the same workflow failure, which could be noisy and confusing.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Refinement of CI notifications and enhancing workflow triggers for user-initiated actions.

πŸ“Š Key Changes

  • πŸ”„ Updated GitHub Actions workflows for more targeted failure notifications.
  • πŸ”§ Removed direct Slack notifications on every failure.
  • πŸ“¬ Replaced with a conditional notification mechanism that checks for failures in specific jobs ('Benchmarks' and 'Tests').
  • πŸš€ Added "workflow_dispatch" to manually trigger workflows for code analysis and Docker image publication.

🎯 Purpose & Impact

  • 🎯 Aim to declutter unnecessary notifications and only alert when crucial jobs fail, increasing attention to significant issues.
  • πŸ’‘ Impact is more streamlined and user-controlled CI processes, giving developers and maintainers better oversight and control over the codebase and deployment pipelines.
  • πŸ‘₯ Non-expert users benefit from a more stable and monitored system, as critical errors are promptly and efficiently managed.

@glenn-jocher glenn-jocher merged commit 22a3cbb into master Apr 29, 2023
9 checks passed
@glenn-jocher glenn-jocher deleted the slack branch April 29, 2023 11:50
bandakopi pushed a commit to irajcode/yolov5 that referenced this pull request Jul 20, 2023
* Improve Slack notification

* Improve Slack notification

* Improve Slack notification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant