Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slack notification of CI errors #11421

Merged
merged 3 commits into from
Apr 23, 2023
Merged

Add Slack notification of CI errors #11421

merged 3 commits into from
Apr 23, 2023

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Apr 23, 2023

πŸ€– Generated by Copilot at 1e88ff9

Summary

πŸ› οΈπŸš€πŸ“

Improved link checker workflow by excluding a testing file. This file contains invalid links that are used to test the link checker tool itself, and should not affect the workflow status.

To check links, we use a handy tool
But it flagged a file meant for testing, how cruel
So we added an argument
To exclude it from the judgment
And now the link checker workflow is cool

Walkthrough

  • Exclude ci-testing.yaml from link checking ([link](https://github.com/ultralytics/yolov5/pull/11421/files?diff=unified&w=0#diff-a618bbaa9618d3ffa70846c5371ca23ea8f71f3370d3aa5be5d2cf39b42b207bL26-R26), [link](https://github.com/ultralytics/yolov5/pull/11421/files?diff=unified&w=0#diff-a618bbaa9618d3ffa70846c5371ca23ea8f71f3370d3aa5be5d2cf39b42b207bL36-R36))

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improvements in CI notifications and link-checking within Ultralytics YOLOv5 workflows.

πŸ“Š Key Changes

  • Added a Slack notification step to Continuous Integration (CI) testing, triggered on failures for scheduled or push events.
  • Updated the link-checker configuration to exclude the ci-testing.yml file, ensuring that checks are more targeted and relevant.

🎯 Purpose & Impact

  • πŸ”” Enhanced Communication: The Slack notification provides real-time alerts on CI failures, allowing for swift action and ensuring continuous code quality.
  • 🚫 Reduced Noise: By excluding ci-testing.yml from link checks, unnecessary checks are avoided, improving workflow efficiency and focusing attention on files that impact the user experience.
  • πŸ›  Improved Maintenance: With these adjustments, maintainers can prioritize critical fixes and contribute to a more stable and reliable software development lifecycle.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher changed the title Update links.yml Add Slack notification of CI errors Apr 23, 2023
@glenn-jocher glenn-jocher merged commit ff6a9ac into master Apr 23, 2023
8 checks passed
@glenn-jocher glenn-jocher deleted the slack branch April 23, 2023 16:38
bandakopi pushed a commit to irajcode/yolov5 that referenced this pull request Jul 20, 2023
* Update links.yml

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Update links

* Update links

---------

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant