Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync signature of cv2.imread and cv2.imwrite #11209

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Sync signature of cv2.imread and cv2.imwrite #11209

merged 2 commits into from
Mar 23, 2023

Conversation

grzegorzk
Copy link
Contributor

@grzegorzk grzegorzk commented Mar 21, 2023

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Simplifying Image Reading and Writing Functions in YOLOv5 πŸ–ΌοΈβœ¨

πŸ“Š Key Changes

  • Renamed parameters in imread and imwrite functions for clarity.
  • Refactored imread to accept filename instead of path.
  • Updated imwrite function to accept filename and img instead of path and im.

🎯 Purpose & Impact

  • 🧬 Consistency: By renaming variables to filename and img, the code becomes more consistent and easier to understand.
  • πŸš€ Readability: The changes make the code more readable, which can help both current and future developers working on the project.
  • πŸ’Ό User Experience: For end-users, these internal changes are unlikely to affect the experience but contribute to a more robust and maintainable codebase.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘‹ Hello @grzegorzk, thank you for submitting a YOLOv5 πŸš€ PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • βœ… Verify your PR is up-to-date with ultralytics/yolov5 master branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • βœ… Verify all YOLOv5 Continuous Integration (CI) checks are passing.
  • βœ… Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

@glenn-jocher glenn-jocher merged commit f095258 into ultralytics:master Mar 23, 2023
@glenn-jocher
Copy link
Member

@grzegorzk PR is merged. Thank you for your contributions to YOLOv5 πŸš€ and Vision AI ⭐

bandakopi pushed a commit to irajcode/yolov5 that referenced this pull request Jul 20, 2023
Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants