Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .pre-commit-config.yaml #11009

Merged
merged 6 commits into from
Feb 18, 2023
Merged

Update .pre-commit-config.yaml #11009

merged 6 commits into from
Feb 18, 2023

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Feb 17, 2023 •
edited by UltralyticsAssistant
Loading

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improved pre-commit checks and broader code formatting for Ultralytics YOLOv5 repository.

📊 Key Changes

  • Enabled more pre-commit hooks for end-of-file fixing, trailing whitespaces, and private key detection.
  • Added import sorting with isort.
  • Restored codespell for spelling checks with a customized ignore-words list.
  • Standardized single quotes and newlines throughout various Python scripts.
  • Conducted miscellaneous code cleanup, including formatting and replacing comments.

🎯 Purpose & Impact

  • Ensures cleaner code with consistent formatting, enhancing readability and maintainability.
  • Helps prevent common typos and accidental commits of sensitive information.
  • Streamlines developer contributions by enforcing coding standards.
  • Minimizes future diffs and merge conflicts caused by formatting discrepancies.

glenn-jocher and others added 6 commits February 17, 2023 20:16
@glenn-jocher
Update .pre-commit-config.yaml
f601a45 
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
94ae5c1 
for more information, see https://pre-commit.ci
@glenn-jocher
Update __init__.py
d9c79dd 
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher
Update .pre-commit-config.yaml
e0e9017 
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher
Pre-commit updates
b4bb77d
@glenn-jocher
Pre-commit updates
1c0342f
@glenn-jocher glenn-jocher merged commit 7a972e8 into master Feb 18, 2023
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch February 18, 2023 00:06
Smfun12 pushed a commit to Smfun12/yolov5 that referenced this pull request Mar 24, 2023
@glenn-jocher @pre-commit-ci @Smfun12
Update .pre-commit-config.yaml (ultralytics#11009)
e588901 
* Update .pre-commit-config.yaml

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update __init__.py

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Update .pre-commit-config.yaml

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Pre-commit updates

* Pre-commit updates

---------

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@glenn-jocher