Fix return value check for subprocess.run #10972

akx · 2023-02-13T12:03:11Z

Subprocess.run does not return an integer.

Regressed in #10944

🛠️ PR Summary

_{Made with ❤️ by Ultralytics Actions}

🌟 Summary

Enhancing file download reliability in the YOLOv5 codebase.

📊 Key Changes

Modified the download script to use the process's return code for checking success.

🎯 Purpose & Impact

Purpose: To ensure that the success of the file download is accurately determined by checking the return code of the curl process rather than the process object itself.
Impact: Improves the reliability of file downloads within the utility scripts, potentially leading to fewer errors and more robust behavior for end-users when setting up YOLOv5 or downloading necessary files. 🛠️

Subprocess.run does not return an integer. Regressed in ultralytics#10944

glenn-jocher · 2023-02-13T13:38:37Z

@akx PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐

Subprocess.run does not return an integer. Regressed in ultralytics#10944

Fix return value check for subprocess.run

5c40445

Subprocess.run does not return an integer. Regressed in ultralytics#10944

glenn-jocher merged commit 1a2eb53 into ultralytics:master Feb 13, 2023

Smfun12 pushed a commit to Smfun12/yolov5 that referenced this pull request Mar 24, 2023

Fix return value check for subprocess.run (ultralytics#10972)

116d44e

Subprocess.run does not return an integer. Regressed in ultralytics#10944

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix return value check for subprocess.run #10972

Fix return value check for subprocess.run #10972

akx commented Feb 13, 2023 •

edited by UltralyticsAssistant

Loading

glenn-jocher commented Feb 13, 2023

Fix return value check for subprocess.run #10972

Fix return value check for subprocess.run #10972

Conversation

akx commented Feb 13, 2023 • edited by UltralyticsAssistant Loading

🛠️ PR Summary

🌟 Summary

📊 Key Changes

🎯 Purpose & Impact

glenn-jocher commented Feb 13, 2023

akx commented Feb 13, 2023 •

edited by UltralyticsAssistant

Loading