Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNN warning comment #10368

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Add DNN warning comment #10368

merged 1 commit into from
Dec 1, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Dec 1, 2022

Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Updated ONNX export settings for compatibility with PyTorch versions.

πŸ“Š Key Changes

  • Added a comment warning regarding the do_constant_folding parameter in ONNX export.
  • No actual code behavior changeβ€”only additional information for developers.

🎯 Purpose & Impact

  • πŸŽ“ The comment is aimed at informing developers that using PyTorch version 1.12 or newer might require setting do_constant_folding=False during ONNX export for successful DNN inference.
  • πŸ”§ This update is a proactive measure to prevent potential issues with ONNX model deployment, ensuring smoother transitions for users upgrading their PyTorch version.
  • πŸ€– Users are unlikely to see immediate changes, but the comment provides crucial insights for troubleshooting and future-proofing their ONNX model exports.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 6.2 and detect.py with onnx & dnn : problems dependent on pytorch version.
1 participant