Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squeezenet reshape outputs fix #10222

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Squeezenet reshape outputs fix #10222

merged 1 commit into from
Nov 19, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 19, 2022

@AyushExel

Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced convolutional layer bias handling in YOLOv5's model utility.

📊 Key Changes

  • Modified the nn.Conv2d constructor in the reshape_classifier_output function to correctly handle whether a bias should be applied.

🎯 Purpose & Impact

  • Consistency: Ensures that when a convolutional layer is reshaped, the bias parameter is maintained according to the original configuration (presence or absence of bias).
  • Reliability: Prior to this change, models that originally did not use bias could have a bias mistakenly introduced, which is fixed now.
  • User Impact: Users will experience improved model manipulation functionality, particularly in custom object classification, with no unexpected behavior regarding bias in convolutional layers.

@AyushExel

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher self-assigned this Nov 19, 2022
@glenn-jocher glenn-jocher merged commit 72cad39 into master Nov 19, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch November 19, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant