Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved check_online() robustness #10000

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 1, 2022

YOLOv5-wide improvement, not just in check_requirements()

Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced internet connectivity check within YOLOv5's utility functions.

πŸ“Š Key Changes

  • Updated the check_online function to attempt the internet connectivity check twice.
  • Simplified the connection check assertion in the check_requirements function.

🎯 Purpose & Impact

  • The double-check for internet connectivity aims to reduce false negatives due to temporary network issues. πŸ“‘βœ…
  • By improving the reliability of the connectivity check, automatic updates and other internet-dependent functionality become more robust, benefiting users with intermittent internet connections. πŸ”—πŸ› οΈ
  • Users may experience fewer disruptions when the system tries to auto-update or perform other net-requiring actions, leading to a smoother experience. πŸŒπŸš€

YOLOv5-wide improvement, not just in check_requirements()

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher changed the title Improved check_online() robustness Improved check_online() robustness Nov 1, 2022
@glenn-jocher glenn-jocher self-assigned this Nov 1, 2022
@glenn-jocher
Copy link
Member Author

10000!

Here's to the next 10000 πŸ₯‚

@glenn-jocher glenn-jocher merged commit 067ad9a into master Nov 1, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-2 branch November 1, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant