Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to run torchscript after exporting #9011

Closed
1 task done
Andy824 opened this issue Aug 18, 2022 · 11 comments · Fixed by #9015
Closed
1 task done

Fail to run torchscript after exporting #9011

Andy824 opened this issue Aug 18, 2022 · 11 comments · Fixed by #9015
Assignees
Labels
bug Something isn't working

Comments

@Andy824
Copy link

Andy824 commented Aug 18, 2022

Search before asking

Question

I run my yolov5 model through colab. It works successfully. However, after exporting my yolov5m best.pt to torchscript format. The error occurs. The error message is as shown below. Does anyone know the reason? Thank you
dawdawd
!
螢幕擷取畫面 2022-08-18 112104

Additional

No response

@Andy824 Andy824 added the question Further information is requested label Aug 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2022

👋 Hello @Andy824, thank you for your interest in YOLOv5 🚀! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset images, training logs, screenshots, and a public link to online W&B logging if available.

For business inquiries or professional support requests please visit https://ultralytics.com or email support@ultralytics.com.

Requirements

Python>=3.7.0 with all requirements.txt installed including PyTorch>=1.7. To get started:

git clone https://github.com/ultralytics/yolov5  # clone
cd yolov5
pip install -r requirements.txt  # install

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

Status

CI CPU testing

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training (train.py), validation (val.py), inference (detect.py) and export (export.py) on macOS, Windows, and Ubuntu every 24 hours and on every commit.

@Andy824
Copy link
Author

Andy824 commented Aug 18, 2022

sucess

@Andy824
Copy link
Author

Andy824 commented Aug 18, 2022

I retrained my model again, but after exporting to torchscript, I got the same error. Does anyone encounter the same problem?

@glenn-jocher
Copy link
Member

@Andy824 thanks for the bug report! We recently updated this section of the code, I'll take a look.

@glenn-jocher
Copy link
Member

@Andy824 I'm not able to reproduce any errors using the pretrained YOLOv5s model exported to torchscript. Are you sure you are using the latest code?
Screenshot 2022-08-18 at 11 06 56

@glenn-jocher
Copy link
Member

@Andy824 EDIT: able to reproduce on custom trained model. Will investigate.

Screenshot 2022-08-18 at 11 10 17

@glenn-jocher glenn-jocher added bug Something isn't working TODO and removed question Further information is requested labels Aug 18, 2022
@glenn-jocher glenn-jocher self-assigned this Aug 18, 2022
@glenn-jocher
Copy link
Member

Traced to JSON dumps converting int keys to strings during export, i.e.
https://stackoverflow.com/questions/1450957/pythons-json-module-converts-int-dictionary-keys-to-strings

@Andy824
Copy link
Author

Andy824 commented Aug 18, 2022

Thank you for your reply~ ^ ^

glenn-jocher added a commit that referenced this issue Aug 18, 2022
Resolves #9011

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
glenn-jocher added a commit that referenced this issue Aug 18, 2022
* Fix TorchScript JSON string key bug

Resolves #9011

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@glenn-jocher
Copy link
Member

@Andy824 good news 😃! Your original issue may now be fixed ✅ in PR #9015. To receive this update:

  • Gitgit pull from within your yolov5/ directory or git clone https://github.com/ultralytics/yolov5 again
  • PyTorch Hub – Force-reload model = torch.hub.load('ultralytics/yolov5', 'yolov5s', force_reload=True)
  • Notebooks – View updated notebooks Open In Colab Open In Kaggle
  • Dockersudo docker pull ultralytics/yolov5:latest to update your image Docker Pulls

Thank you for spotting this issue and informing us of the problem. Please let us know if this update resolves the issue for you, and feel free to inform us of any other issues you discover or feature requests that come to mind. Happy trainings with YOLOv5 🚀!

@glenn-jocher glenn-jocher removed the TODO label Aug 18, 2022
@Andy824
Copy link
Author

Andy824 commented Aug 18, 2022

Thank you very much

ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this issue Sep 8, 2022
* Fix TorchScript JSON string key bug

Resolves ultralytics#9011

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@glenn-jocher
Copy link
Member

@Andy824 you're very welcome! I'm here anytime if you have more questions, feature requests or bug reports. Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants