Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

val.py --task speed parser parameter return nothing #5600

Closed
2 tasks done
Haebuk opened this issue Nov 10, 2021 · 2 comments · Fixed by #5608
Closed
2 tasks done

val.py --task speed parser parameter return nothing #5600

Haebuk opened this issue Nov 10, 2021 · 2 comments · Fixed by #5608
Labels
bug Something isn't working

Comments

@Haebuk
Copy link

Haebuk commented Nov 10, 2021

Search before asking

  • I have searched the YOLOv5 issues and found no similar bug report.

YOLOv5 Component

Validation

Bug

When excuting val.py with --task speed, the --name parser parameter is ignored and return nothing.

$python yolov5/val.py --data VisDrone.yaml --name bug-testing --weights YOLOv5/yolov5n/weights/best.pt --task speed

...

Results saved to yolov5/runs/val/exp5

Environment

  • YOLO: YOLOv5 🚀 v6.0-74-gb8f979b torch 1.10.0+cu113 CUDA:0 (NVIDIA GeForce RTX 3080 Ti, 12051MiB)
  • OS: Ubuntu 20.
  • Python: 3.8.12

Minimal Reproducible Example

python val.py --data VisDrone.yaml --task speed --name bug-test
> Result saved to yolov5/runs/val/exp (not bug-test, and there is no file in the folder)

Additional

When excuting the shell without --task parser, It returns well.

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@Haebuk Haebuk added the bug Something isn't working label Nov 10, 2021
@glenn-jocher
Copy link
Member

@Haebuk thanks for the bug report! --project and --name should always be used to create your save_dir = project/name. I'll take a look.

glenn-jocher added a commit that referenced this issue Nov 10, 2021
Accepts all arguments now by default resolving #5600
@glenn-jocher glenn-jocher linked a pull request Nov 10, 2021 that will close this issue
glenn-jocher added a commit that referenced this issue Nov 10, 2021
Accepts all arguments now by default resolving #5600
@glenn-jocher
Copy link
Member

glenn-jocher commented Nov 10, 2021

@Haebuk good news 😃! Your original issue may now be fixed ✅ in PR #5608. This PR updated val.py to pass all arguments by default to all tasks. Note though that --task speed will not produce any saved output, the results are simply displayed to screen.

There was a separate PR #5341 which attempted to log console outputs to text file also, but this is still in progress.

To receive this update:

  • Gitgit pull from within your yolov5/ directory or git clone https://github.com/ultralytics/yolov5 again
  • PyTorch Hub – Force-reload model = torch.hub.load('ultralytics/yolov5', 'yolov5s', force_reload=True)
  • Notebooks – View updated notebooks Open In Colab Open In Kaggle
  • Dockersudo docker pull ultralytics/yolov5:latest to update your image Docker Pulls

Thank you for spotting this issue and informing us of the problem. Please let us know if this update resolves the issue for you, and feel free to inform us of any other issues you discover or feature requests that come to mind. Happy trainings with YOLOv5 🚀!

@glenn-jocher glenn-jocher removed the TODO label Nov 10, 2021
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this issue Aug 26, 2022
Accepts all arguments now by default resolving ultralytics#5600
SecretStar112 added a commit to SecretStar112/yolov5 that referenced this issue May 24, 2023
Accepts all arguments now by default resolving ultralytics/yolov5#5600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants