Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solutions updates #9548

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

RizwanMunawar
Copy link
Member

@RizwanMunawar RizwanMunawar commented Apr 4, 2024

@glenn-jocher

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhancements in heatmap and object counting features for better visualization and usability.

πŸ“Š Key Changes

  • πŸ–Ό Introduction of a new parameter line_thickness to increase the thickness of bounding boxes and count text.
  • 🎨 Modification in text and background colors to improve readability.
  • βœ‚ Reduction of certain parameters like count_txt_thickness, fontsize, and line_color for simplification.
  • πŸ›  Code refactoring to improve clarity and maintainability, including adjustments in method calls and parameter lists.

🎯 Purpose & Impact

  • Enhanced Visibility: The increase in line_thickness makes it easier for users to recognize bounding boxes and read count texts on various backgrounds.
  • Improved Readability: Changes in text and background colors ensure that count texts are more readable against diverse video frames or images.
  • Simplified Configuration: The removal and consolidation of parameters reduce complexity, making the configuration process more straightforward for users.
  • Code Maintenance: Refactoring efforts lead to a cleaner, more understandable codebase, facilitating further developments and bug fixes.

Overall, these updates aim to enhance user experience by offering clearer visuals and simplifying the customization process, broadening the tool's applicability in real-world scenarios.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 74.08%. Comparing base (207bba1) to head (b96cc49).

❗ Current head b96cc49 differs from pull request most recent head 1d78bbb. Consider uploading reports for the commit 1d78bbb to get more accurate results

Files Patch % Lines
ultralytics/utils/plotting.py 10.00% 9 Missing ⚠️
ultralytics/solutions/heatmap.py 0.00% 7 Missing ⚠️
ultralytics/solutions/object_counter.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9548      +/-   ##
==========================================
- Coverage   79.10%   74.08%   -5.03%     
==========================================
  Files         121      121              
  Lines       15278    15272       -6     
==========================================
- Hits        12086    11314     -772     
- Misses       3192     3958     +766     
Flag Coverage Ξ”
Benchmarks 36.07% <4.34%> (+0.01%) ⬆️
GPU ?
Tests 71.43% <4.34%> (-3.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@glenn-jocher glenn-jocher merged commit e597bed into ultralytics:main Apr 5, 2024
@glenn-jocher
Copy link
Member

@RizwanMunawar looks good!

@RizwanMunawar RizwanMunawar deleted the solution_updates branch April 5, 2024 09:49
hmurari pushed a commit to hmurari/ultralytics that referenced this pull request Apr 17, 2024
Co-authored-by: UltralyticsAssistant <web@ultralytics.com>
gkinman pushed a commit to Octasic/ultralytics that referenced this pull request May 30, 2024
Co-authored-by: UltralyticsAssistant <web@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants