Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled stream response from upload endpoints #89

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

hassaanfarooq01
Copy link
Contributor

@hassaanfarooq01 hassaanfarooq01 commented Jan 22, 2024

Issue: Ultralytics upload model progress bar turns from 0 to 100 directly.
Fix: Handled stream response from upload endpoints

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced HTTP POST functionality with stream support in Ultralytics hub-sdk.

📊 Key Changes

  • Added stream parameter to the post method in api_client.py.
  • Enabled streaming uploads in upload_model and upload_dataset within server_clients.py.

🎯 Purpose & Impact

  • Purpose: Incorporating streaming support allows large files to be uploaded more efficiently by sending the request as a continuous stream.
  • Impact: Users uploading large models or datasets to Ultralytics services will experience more stable and possibly faster uploads, reducing the chance of timeout errors. This improvement can significantly enhance user experience when dealing with heavy data operations. 🚀📈

@kalenmike kalenmike merged commit cf023c0 into develop Jan 23, 2024
3 checks passed
@kalenmike kalenmike deleted the fix/ultralytics-progress-bar-issue branch January 23, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants