Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIHC] Brand bar #925

Merged
merged 13 commits into from
May 22, 2024
Merged

[UIHC] Brand bar #925

merged 13 commits into from
May 22, 2024

Conversation

bspeare
Copy link
Contributor

@bspeare bspeare commented May 17, 2024

How to test

yarn storybook

Notes:

  • Sticky header CSS was moved out of brand-bar.scss to uids_base since that is where the JavaScript for that implementation lives.
  • base/reset was moved to the first line of uids-core.scss by request of Dustin Quam.

@bspeare bspeare marked this pull request as ready for review May 21, 2024 15:27
@bspeare bspeare requested a review from a team May 21, 2024 15:27
@pyrello pyrello self-assigned this May 21, 2024
@pyrello
Copy link
Contributor

pyrello commented May 21, 2024

Pulling to test.

Copy link
Contributor

@pyrello pyrello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update looks good.

@pyrello pyrello merged commit 696c565 into 4.x May 22, 2024
2 checks passed
@pyrello pyrello deleted the uihc_logo branch May 22, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants